[Webkit-unassigned] [Bug 175259] [GTK] Implement JavaScript dialog methods of API::AutomationSessionClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175259

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com
 Attachment #317408|review?                     |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 317408
  --> https://bugs.webkit.org/attachment.cgi?id=317408
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317408&action=review

> Source/WebCore/platform/gtk/po/POTFILES.in:33
> +../../../WebKit/UIProcess/API/gtk/WebKitScriptDialogGtk.cpp

Do we have a script that reminds you to do this, or are you the hero of the translators?

> Source/WebKit/ChangeLog:11
> +        files. Implement all JavaScript dialog methods of API::AutomationSessionClient in WebKitAutomationSession. For
> +        now it only works when the user doesn't override WebKitWebView::script-dialog signal and default implementation
> +        is used.

Well that's a significant limitation.

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2051
> +    // FIXME: Add API to ask the user in case default implementation is not being used.

What should that API look like?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170807/1c77976a/attachment.html>