[Webkit-unassigned] [Bug 174614] WebDriver: implement user prompt commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174614

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Brian Burg from comment #3)
> Comment on attachment 317406 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317406&action=review
> 
> r=me

Thanks!

> > Source/WebDriver/Session.cpp:1525
> > +void Session::sendAlertText(const String& text, Function<void (CommandResult&&)>&& completionHandler)
> 
> Nit: 'setAlertText' would match 'getAlertText'

I agree, but I'm using the spec names in all other commands. . .

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170807/05c2555d/attachment.html>