[Webkit-unassigned] [Bug 175130] [GTK][WPE] Add API to provide browser information required by automation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175130

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Brian Burg from comment #3)
> Comment on attachment 317116 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317116&action=review
> 
> Source/JavaScriptCore and Source/WebDriver parts look good to me. Please
> find a GTK reviewer for the rest.
> 
> > Source/JavaScriptCore/inspector/remote/RemoteInspector.h:70
> > +            String browserName;
> 
> Perhaps we can conditionalize these for GTK/WPE, I don't think
> Safari/safaridriver needs them at present and this patch doesn't update the
> capability caching code for these keys. Each Safari (Safari Technology
> Preview, system Safari, engineering builds) have their own copy of
> safaridriver so there is no matching to be done on the browser side.

My idea was to make it glib only initially, but I think this doesn't hurt when unused and we leave cleaner code without ifdefs.

> I think we'll want to have the ability to report and request capabilities
> for some other things, however.
> 
> > Source/JavaScriptCore/inspector/remote/RemoteInspector.h:93
> > +    std::optional<RemoteInspector::Client::Capabilities> clientCapabilities() const { return m_clientCapabilities; }
> 
> OK

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170805/40e6a12d/attachment.html>