[Webkit-unassigned] [Bug 174618] WebDriver: properly handle capabilities and process firstMatch too

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174618

--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 317108
  --> https://bugs.webkit.org/attachment.cgi?id=317108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317108&action=review

>>> Source/WebDriver/WebDriverService.cpp:325
>>> +        if (it->value->isNull())
>> 
>> This section may be easier to read if you add comments to mark off cases by the type of the value (bool, string, enum). Alternatively, you could parse the capability key in a separate function and turn this into a switch to check the types of already parsed keys. If key parsing fails (unknown capability), then the entire thing fails. That will also centralize where we need to maintain the list of "known" capabilities.
> 
> I'm not sure I follow what you mean here. What would the function parsing the key return?

I want to land this, because two other patches depend on this one. I'll make any refactoring to this method in a follow up, once I understand what you propose here :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170805/c74c22fc/attachment.html>