[Webkit-unassigned] [Bug 175130] [GTK][WPE] Add API to provide browser information required by automation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 5 00:38:52 PDT 2017


--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #5)
> Comment on attachment 317116 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317116&action=review
> > Source/WebKit/UIProcess/API/glib/WebKitApplicationInfo.cpp:136
> > + * Set the application version. If the application doesn't use the format
> > + * major.minor.micro you can pass 0 as the micro to use major.minor, or pass
> > + * 0 as both micro and minor to use only major number. Any other format must
> > + * be converted to major.minor.micro so that it can be used in version comparisons.
> What about nano versions? I do nano versions for Epiphany on occasion.
> This API is too limiting. I would make it variadic so the user can add any
> desired number of decimal places.

I don't think we need that level of detail. This is used for drivers to request a  minimum version of the browser, normally because it has a new feature required or something like that, I doubt we really need to require a nano version ever. Also, this should work for projects using any other version formats, they are expected to convert them into x.y.z ensuring they can be compared. So, the selenium driver is always going to use x.y.x format.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170805/2ee13006/attachment-0001.html>

More information about the webkit-unassigned mailing list