[Webkit-unassigned] [Bug 174618] WebDriver: properly handle capabilities and process firstMatch too

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174618

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #317108|review?                     |review+
              Flags|                            |

--- Comment #10 from Brian Burg <bburg at apple.com> ---
Comment on attachment 317108
  --> https://bugs.webkit.org/attachment.cgi?id=317108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317108&action=review

r=me

Please fix the capability parsing vs matching so that unimplemented ones are recognized but not matchable.

> Source/WebDriver/WebDriverService.cpp:451
> +    if (!capabilitiesObject->getValue(ASCIILiteral("firstMatch"), firstMatchCapabilitiesValue)) {

Referencing steps in the spec would help here, as the names here are quite verbose yet not clear what the logic is.

> Source/WebDriver/WebDriverService.cpp:481
> +            completionHandler(CommandResult::fail(CommandResult::ErrorCode::SessionNotCreated, String("Invalid capabilities")));

The error message could be better. This should only fail if a capability is in both firstMatch and alwaysMatch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170804/bb77f471/attachment-0001.html>