[Webkit-unassigned] [Bug 175126] New: REGRESSION(r219850): run-benchmark script broken on Linux

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 3 04:32:51 PDT 2017


            Bug ID: 175126
           Summary: REGRESSION(r219850): run-benchmark script broken on
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: cgarcia at igalia.com, lforschler at apple.com,
                    matthew_r_stewart at apple.com, slewis at apple.com
            Blocks: 174445

The run-benchmark script dynamically generates the list of supported browsers and platforms (currently linux and osx) by loading all python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver and getting the browser_name and platform variables from the classes defined there.

This means, that this classes should never raise an exception when loaded on other platforms or otherwise they will broke the whole script. Its fine if they raise an exception when executing on any of the methods they implement, but not when just loading/importing the class.

So, yo avoid raising exceptions on another platforms we load the python modules that are platform specific on the functions rather than on the main file or the main class body. Example: https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py?rev=216213#L110

On r219850 <https://trac.webkit.org/r219850> a method for _screen_size() was added also for the OSX platform, but this method is called from the main file so its evaluated when the load of the classes is done to get the lists of platforms an browsers. Therefore it aborts on Linux like this:


Referenced Bugs:

[Bug 174445] Add WebDriver support in browser driver part of BenchmarkRunner
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170803/0a2151d7/attachment.html>

More information about the webkit-unassigned mailing list