[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 2 16:08:24 PDT 2017


--- Comment #17 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 316993
  --> https://bugs.webkit.org/attachment.cgi?id=316993

View in context: https://bugs.webkit.org/attachment.cgi?id=316993&action=review

>>> Source/WebCore/html/HTMLInputElement.h:77
>>> +    WEBCORE_EXPORT URL representingPageUrl();
>> Could we instead ask the Document directly for the page url instead of adding a new HTMLInputElement method to do this? It seems a bit odd to specifically teach the HTMLInputElement about the document URL.
> Yeah, that makes sense to access the Document directly. I added this variable here to able to access it from DOMHTMLInputElement. I could not figure out how to access the document/page from there directly.

I believe DOMHTMLInputElement has an ownerDocument property, which has an URL property. This calls into Document::urlForBindings()

>>> Source/WebKit/Platform/spi/ios/UIKitSPI.h:46
>>> +#import <UIKit/UIKeyboardLoginCredentialsSuggestion.h>
>> If this is a new header, this will need to be ifdef'ed out for this to compile on older iOSes.
> Is this DYLD_IOS_VERSION_11_0?

Assuming this is in iOS 11, __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000 is what you want.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170802/7cbab0ea/attachment.html>

More information about the webkit-unassigned mailing list