[Webkit-unassigned] [Bug 171443] AX: Improve performance of addChildren()/childrenChanged()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 28 17:34:44 PDT 2017


--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 308572
  --> https://bugs.webkit.org/attachment.cgi?id=308572

View in context: https://bugs.webkit.org/attachment.cgi?id=308572&action=review

>>> Source/WebCore/ChangeLog:22
>>> +        No new tests since this didn't change any functionality. 
>> I think we could add a test for this by getting a reference to an axObject, marking a subtree dirty, then verifying that reference (in the test) is still valid
>> in the old case, that element would have become invalid because it was thrown away and recreated. In the new case it should still be there even after the sub tree was cleared (likewise, we can probably get a reference to a dirty subtree object and ensure that it is indeed invalid after the update)
> I think in the old case, the element is still valid since its children list is being cleared instead of itself being thrown away. Here we just reduce the work that is traversing the non affected subtree and retrieving the element that supposed to be a child.

What if we modify my comment instead of grabbing the parent we grab a sibling (or child of that sibling) child and verify that that is not thrown away

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170429/72e1b1c6/attachment.html>

More information about the webkit-unassigned mailing list