[Webkit-unassigned] [Bug 171443] AX: Improve performance of addChildren()/childrenChanged()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 28 17:07:06 PDT 2017


--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 308572
  --> https://bugs.webkit.org/attachment.cgi?id=308572

View in context: https://bugs.webkit.org/attachment.cgi?id=308572&action=review

> Source/WebCore/ChangeLog:8
> +        There's a lot of unnecessary work happening when childrenChanged() being called.

"is" being called

> Source/WebCore/ChangeLog:15
> +        2. In addChild() method we are calling accessibilityIsIgnored() on each child and that 

In the...

> Source/WebCore/ChangeLog:19
> +        3. Reduced the amount work of ARIA text controls updating its parents in childrenChanged() 

text controls "performs when" updating

> Source/WebCore/ChangeLog:22
> +        No new tests since this didn't change any functionality. 

I think we could add a test for this by getting a reference to an axObject, marking a subtree dirty, then verifying that reference (in the test) is still valid

in the old case, that element would have become invalid because it was thrown away and recreated. In the new case it should still be there even after the sub tree was cleared (likewise, we can probably get a reference to a dirty subtree object and ensure that it is indeed invalid after the update)

> Source/WebCore/ChangeLog:38
> +        (WebCore::AccessibilityObject::setNeedsToUpdateSubTree):

I suspect SubTree should be Subtree (pls check if there are other instances in WebKit code)

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:348
> +    // Only clear the child's children when we know it's in the updating chain in order to avoid unnecessary works.


> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:351
> +        // Pass m_subTreeDirty flag down to the child so that children cache get reset properly.


> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:376
> +    // reset the child's m_isIgnoredFromParentData since we are done adding that child and its children.


> Source/WebCore/accessibility/AccessibilityObject.h:1095
> +    void setIsIgnoredFromParentData(AccessibilityIsIgnoredFromParentData data) { m_isIgnoredFromParentData = data; }

should this be AccessibilityIsIgnoredFromParentData&

> Source/WebCore/accessibility/AccessibilityObject.h:1096
> +    void setIsIgnoredFromParentDataForChild(AccessibilityObject*);

const AccessibilityObject

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170429/9716194c/attachment.html>

More information about the webkit-unassigned mailing list