[Webkit-unassigned] [Bug 171424] New: check-webkit-style should keep JavaScript test functions in sync
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 28 02:37:54 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=171424
Bug ID: 171424
Summary: check-webkit-style should keep JavaScript test
functions in sync
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
Assignee: webkit-unassigned at lists.webkit.org
Reporter: ddkilzer at webkit.org
CC: ap at webkit.org, joepeck at webkit.org,
keith_miller at apple.com, lforschler at apple.com
Depends on: 171362
JavaScript test methods like shouldBe(), shouldNotBe(), shouldNotThrow() and shouldThrow() (among many others) have been copied into multiple source files:
JSTests/stress/resources/standalone-pre.js
LayoutTests/http/tests/resources/js-test-pre.js
LayoutTests/resources/js-test-pre.js
LayoutTests/resources/js-test.js
LayoutTests/resources/standalone-pre.js
Additionally, js-test-pre.js has actually been copied from LayoutTests/resources/ to LayoutTests/http/tests/resources/ so that http tests may use it.
The check-webkit-style script should try to keep these multiple copies in sync until a better solution is available:
$ ./Tools/Scripts/check-webkit-style --git-index
ERROR: JSTests/stress/resources/standalone-pre.js:0: Changes to function shouldBe() should be kept in sync with LayoutTests/http/tests/resources/js-test-pre.js. [jstest/function_equality] [5]
ERROR: LayoutTests/resources/js-test-pre.js:0: Changes should be kept in sync with LayoutTests/http/tests/resources/js-test-pre.js. [jstest/resource_equality] [5]
ERROR: LayoutTests/resources/js-test-pre.js:0: Changes to function shouldBe() should be kept in sync with LayoutTests/http/tests/resources/js-test-pre.js. [jstest/function_equality] [5]
ERROR: LayoutTests/resources/js-test-pre.js:0: Changes to function shouldNotBe() should be kept in sync with LayoutTests/http/tests/resources/js-test-pre.js. [jstest/function_equality] [5]
ERROR: LayoutTests/resources/js-test-pre.js:0: Changes to function shouldNotBe() should be kept in sync with LayoutTests/resources/js-test.js. [jstest/function_equality] [5]
ERROR: LayoutTests/resources/js-test-pre.js:0: Changes to function shouldNotBe() should be kept in sync with LayoutTests/resources/standalone-pre.js. [jstest/function_equality] [5]
ERROR: LayoutTests/resources/standalone-pre.js:0: Changes to function shouldBe() should be kept in sync with LayoutTests/http/tests/resources/js-test-pre.js. [jstest/function_equality] [5]
ERROR: LayoutTests/resources/standalone-pre.js:0: Changes to function shouldNotBe() should be kept in sync with LayoutTests/resources/js-test.js. [jstest/function_equality] [5]
Total errors found: 8 in 6 files
Referenced Bugs:
https://bugs.webkit.org/show_bug.cgi?id=171362
[Bug 171362] Enhance shouldBe()/shouldNotBe() to accept anonymous function arguments
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170428/8c335840/attachment-0001.html>
More information about the webkit-unassigned
mailing list