[Webkit-unassigned] [Bug 171363] New: Web Inspector: ASSERT(!m_startedComposite) fails when recording on non-Cocoa Timeline

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 26 20:04:10 PDT 2017


            Bug ID: 171363
           Summary: Web Inspector: ASSERT(!m_startedComposite) fails when
                    recording on non-Cocoa Timeline
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ross.kirsling at sony.com
                CC: inspector-bugzilla-changes at group.apple.com

It appears that when compositing events were implemented, this wasn't done in an entirely safe fashion for non-Cocoa platforms:

Specifically, the asserts for InspectorTimelineAgent::willComposite and InspectorTimelineAgent::didComposite ensure that one is not used without the other, yet didComposite is called within a PLATFORM(COCOA) block while willComposite is called on all platforms.

Asserts:                https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp#L358
didComposite callsite:  https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp#L196
willComposite callsite: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/page/FrameView.cpp#L1234

As such, on any non-Cocoa platform, the second compositing event in a timeline recording causes an assertion failure.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170427/c43490cc/attachment.html>

More information about the webkit-unassigned mailing list