[Webkit-unassigned] [Bug 170849] A blob created from a fetch response does not correctly get type set

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 25 20:23:41 PDT 2017


--- Comment #5 from youenn fablet <youennf at gmail.com> ---
> This should update the Response content-type after headers are received. 
> Its covered by a web-platform-test, but I'm not sure if there is something I
> need to do in webkit to indicate that the test works now.
> Also, I apologize if I made this patch incorrectly.  Its my first time
> submitting here.


The patch is almost right, the ChangeLog looks great.
There is a problem with the file paths though, since you should target Source/WebCore/ChangeLog and Source/WebCore/Modules/fetch/FetchResponse.cpp, not ChangeLog and Modules/fetch/FetchResponse.cpp.

If you have a WebKit git clone, you might be able to use the command below, assuming that your changes and ChangeLog are all in the last commit:
Tools/Scripts/webkit-patch upload -g HEAD~1..HEAD
Or if you are in master and your changes are not committed:
Tools/Scripts/webkit-patch upload

http://w3c-test.org/fetch/api/response/response-consume.html should translate to LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume.html.

You might need to update LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-expected.txt as a test might go from FAIL to PASS.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170426/b7959518/attachment-0001.html>

More information about the webkit-unassigned mailing list