[Webkit-unassigned] [Bug 171240] [Win] Use Clang's __has_declspec_attribute for export macros

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 25 11:01:15 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=171240

--- Comment #4 from Don Olmstead <don.olmstead at am.sony.com> ---
(In reply to Alex Christensen from comment #3)
> Comment on attachment 307995 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307995&action=review
> 
> > Source/WTF/wtf/Platform.h:440
> > +#if OS(WINDOWS) \
> > +    || (COMPILER_HAS_CLANG_DECLSPEC(dllimport) && COMPILER_HAS_CLANG_DECLSPEC(dllexport))
> 
> These can be on one line.
> Also, if it has __declspec(dllimport) can't we assume it has
> __declspec(dllexport)?

I would assume that would be the case but just made it completely explicit. Can change that.

> 
> > Source/WTF/wtf/Platform.h:441
> > +#define USE_DECLSPEC_ATTRIBUTE 1
> 
> __declspec is a keyword according to
> https://msdn.microsoft.com/en-us/library/dabb5z75.aspx
> I wish clang had used __has_declspec_keyword, but they didn't.
> 
> > Source/WTF/wtf/Platform.h:443
> > +#elif defined(__GNUC__) && !defined(__CC_ARM) && !defined(__ARMCC__)
> 
> Is there no visibility attribute on ARM?

That line has actually been there since the first commit of ExportMacros.h so its over 6 years old. I'm not sure the initial thinking of it. Should we just remove it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170425/0d09d02e/attachment.html>


More information about the webkit-unassigned mailing list