[Webkit-unassigned] [Bug 171060] REGRESSION (r215469): [ios-simulator-wk2] LayoutTest compositing/animation/animation-backing.html is a flaky failure

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 25 08:46:35 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=171060

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307968|review?                     |review-
              Flags|                            |

--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 307968
  --> https://bugs.webkit.org/attachment.cgi?id=307968
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307968&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:961
> +    bool hasAcceleratedTransformAnimation = renderer().animation().isRunningAcceleratedAnimationOnRenderer(renderer(), CSSPropertyTransform, AnimationBase::Running | AnimationBase::Paused);
> +    m_graphicsLayer->setHasAcceleratedTransformAnimation(hasAcceleratedTransformAnimation);
> +    if (!hasAcceleratedTransformAnimation)

I don't think you need to set this from outside of GraphicsLayer(CA). GraphicsLayerCA::isRunningTransformAnimation() knows this, and GraphicsLayerCA::updateAnimations() can set or clear the state.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170425/642d39d9/attachment-0001.html>


More information about the webkit-unassigned mailing list