[Webkit-unassigned] [Bug 171268] New: Rename MockFileSystem.maybe_make_directory()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 25 03:36:15 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=171268

            Bug ID: 171268
           Summary: Rename MockFileSystem.maybe_make_directory()
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: lforschler at apple.com

The name maybe_make_directory is pretty confusing as it suggest the function may fail to create the directory.

The function is this:


    def maybe_make_directory(self, *path):
        norm_path = self.normpath(self.join(*path))
        while norm_path and not self.isdir(norm_path):
            self.dirs.add(norm_path)
            norm_path = self.dirname(norm_path)

https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py?rev=215715#L279

So I understand it behaves exactly like "mkdir -p"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170425/e68ec55b/attachment.html>


More information about the webkit-unassigned mailing list