[Webkit-unassigned] [Bug 166680] [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166680

--- Comment #30 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #28)
> (In reply to Carlos Alberto Lopez Perez from comment #26)
> > (In reply to Carlos Garcia Campos from comment #25)
> > > Committed r215683: <http://trac.webkit.org/changeset/215683>
> > 
> > This failed to build on our minimum dependencies baseline bot for Debian
> > stable:
> > 
> > https://build.webkit.org/builders/GTK%20Linux%2064-
> > bit%20Release%20Debian%20Stable%20%28Build%29/builds/1047/steps/compile-
> > webkit/logs/stdio
> 
> I noticed it yesterday, but didn't have time to fix it, I'll do it today.

The build failure is because gtk_window_set_titlebar() is available since 3.10, but gtk_window_get_titlebar() was added in 3.16. That's probably why in WebInspectorProxy we keep a pointer to the header bar. Anyway, I had plans to add a WebKitInspectorWindow to be used by both WebInspectorProxy and RemoteWebInspectorProxy, so I'll do that and fix the build at the same time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170425/84e19077/attachment.html>