[Webkit-unassigned] [Bug 170959] [GTK] Building Webkit2Gtk without OpenGL fails.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 24 17:41:07 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170959

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clopez at igalia.com

--- Comment #2 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Thanks for the patch.

Some comments:

* All patches need to have the proper Changelog entries
* Don't edit files unrelated to your patch (even if it is only removing a trailing space or extra line)
* When you think the patch is ready for review, please upload it with the flag r? (the tool webkit-patch upload will do that for you)

Check: https://webkit.org/contributing-code/

Very summarized the process for git users is the following:

1. Commit to a local git branch your patch.
2. Generate a changelog for it as follows:
$ Tools/Scripts/prepare-ChangeLog -b $bugnumer -g $sha1hashofthecommit
3. Edit the changelogs and commit them amending the previous commit
4. Upload the patch here using this:
$ Tools/Scripts/webkit-patch upload -g $sha1hashofthenewammendedcommit --suggest-reviewers --request-commit

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170425/b6cba0cd/attachment.html>


More information about the webkit-unassigned mailing list