[Webkit-unassigned] [Bug 171240] [Win] Use Clang's __has_declspec_attribute for export macros
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 24 16:25:16 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=171240
Alex Christensen <achristensen at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |achristensen at apple.com
--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 307995
--> https://bugs.webkit.org/attachment.cgi?id=307995
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=307995&action=review
> Source/WTF/wtf/Platform.h:440
> +#if OS(WINDOWS) \
> + || (COMPILER_HAS_CLANG_DECLSPEC(dllimport) && COMPILER_HAS_CLANG_DECLSPEC(dllexport))
These can be on one line.
Also, if it has __declspec(dllimport) can't we assume it has __declspec(dllexport)?
> Source/WTF/wtf/Platform.h:441
> +#define USE_DECLSPEC_ATTRIBUTE 1
__declspec is a keyword according to https://msdn.microsoft.com/en-us/library/dabb5z75.aspx
I wish clang had used __has_declspec_keyword, but they didn't.
> Source/WTF/wtf/Platform.h:443
> +#elif defined(__GNUC__) && !defined(__CC_ARM) && !defined(__ARMCC__)
Is there no visibility attribute on ARM?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170424/3b5ef070/attachment.html>
More information about the webkit-unassigned
mailing list