[Webkit-unassigned] [Bug 166680] [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 24 08:27:17 PDT 2017


--- Comment #23 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 307969
  --> https://bugs.webkit.org/attachment.cgi?id=307969
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307969&action=review

>> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp:89
>> +{
> I assume the mutex is already taken when this is called, right?


>> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp:201
>> +{
> Do you need to lock the mutex here? If not, why not?

It's always called with the mutex locked.

>> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp:343
>> +{
> Do you need to lock the mutex here? If not, why not?

This is tricky. In case of web automation, there's a RemoteInspector in the UI process. The mutex is only needed in the web process, in the UI process the remote inspector is only used from the main thread.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170424/f435a810/attachment.html>

More information about the webkit-unassigned mailing list