[Webkit-unassigned] [Bug 166680] [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 24 07:18:07 PDT 2017


--- Comment #20 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 307969
  --> https://bugs.webkit.org/attachment.cgi?id=307969
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307969&action=review

> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp:89
> +void RemoteInspector::stopInternal(StopSource)
> +{

I assume the mutex is already taken when this is called, right?

> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp:201
> +void RemoteInspector::pushListingsNow()
> +{

Do you need to lock the mutex here? If not, why not?

> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp:343
> +void RemoteInspector::requestAutomationSession(const char* sessionID)
> +{

Do you need to lock the mutex here? If not, why not?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170424/876ce225/attachment-0001.html>

More information about the webkit-unassigned mailing list