[Webkit-unassigned] [Bug 171121] obsolete_attachment should not fail when flags do not exist

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 21 15:47:20 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=171121

--- Comment #3 from Olivier Blin <olivier.blin at softathome.com> ---
Comment on attachment 307752
  --> https://bugs.webkit.org/attachment.cgi?id=307752
Patch

>-        self._find_select_element_for_flag('review').value = ("X",)
>-        self._find_select_element_for_flag('commit-queue').value = ("X",)
>+        try:
>+            self._find_select_element_for_flag('review').value = ("X",)
>+            self._find_select_element_for_flag('commit-queue').value = ("X",)
>+        except:
>+            pass

Actually, maybe it would be better to have one try/catch per flag, if only one of these select is present on the attachment details page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170421/b8de84da/attachment.html>


More information about the webkit-unassigned mailing list