[Webkit-unassigned] [Bug 171121] New: obsolete_attachment should not fail when flags do not exist

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 21 10:51:24 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=171121

            Bug ID: 171121
           Summary: obsolete_attachment should not fail when flags do not
                    exist
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: olivier.blin at softathome.com
                CC: aakash_jain at apple.com, ap at webkit.org,
                    dbates at webkit.org, lforschler at apple.com

./Tools/Scripts/webkit-patch upload 113124 -g HEAD 
Total errors found: 0 in 5 files
Was that diff correct? [Y/n]: 
Please enter password for encrypted keyring: 
Logging in as olivier.blin at softathome.com...
Fetching: https://bugs.webkit.org/show_bug.cgi?id=113124&ctype=xml&excludefield=attachmentdata
Obsoleting 1 old patch on bug 113124
Obsoleting attachment: 195692
"webkit-patch upload" fails in obsolete_attachment when review/commit-queue flags do not exist.

This occurred on https://bugs.webkit.org/attachment.cgi?id=195692&action=edit

./Tools/Scripts/webkit-patch upload 113124 -g HEAD 
Total errors found: 0 in 5 files
Was that diff correct? [Y/n]: 
Please enter password for encrypted keyring: 
Logging in as olivier.blin at softathome.com...
Fetching: https://bugs.webkit.org/show_bug.cgi?id=113124&ctype=xml&excludefield=attachmentdata
Obsoleting 1 old patch on bug 113124
Obsoleting attachment: 195692
Traceback (most recent call last):
  File "./Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "./Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/home/sah0146/vc/webkit.org/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/home/sah0146/vc/webkit.org/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/home/sah0146/vc/webkit.org/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/home/sah0146/vc/webkit.org/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/home/sah0146/vc/webkit.org/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/home/sah0146/vc/webkit.org/WebKit/Tools/Scripts/webkitpy/tool/steps/obsoletepatches.py", line 54, in run
    self._tool.bugs.obsolete_attachment(patch.id())
  File "/home/sah0146/vc/webkit.org/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 790, in obsolete_attachment
    self._find_select_element_for_flag('review').value = ("X",)
  File "/home/sah0146/vc/webkit.org/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 735, in _find_select_element_for_flag
    return self.browser.find_control(type='select', nr=0)
  File "/home/sah0146/vc/webkit.org/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 3101, in find_control
    return self._find_control(name, type, kind, id, label, predicate, nr)
  File "/home/sah0146/vc/webkit.org/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 3185, in _find_control
    raise ControlNotFoundError("no control matching "+description)
webkitpy.thirdparty.autoinstalled.mechanize._form.ControlNotFoundError: no control matching type 'select'

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170421/b86fc5c1/attachment.html>


More information about the webkit-unassigned mailing list