[Webkit-unassigned] [Bug 170986] Avoid repaints for invisible animations on tumblr.com/search/aww

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 20 10:44:11 PDT 2017


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |darin at apple.com

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 307475
  --> https://bugs.webkit.org/attachment.cgi?id=307475

View in context: https://bugs.webkit.org/attachment.cgi?id=307475&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:852
> +    if (style.visibility() == HIDDEN)
> +        return false;
> +    if (!style.opacity())
> +        return false;
> +    return true;

Not at all critical but I would have liked writing it like this:

    return style.visibility() != HIDDEN && style.opacity();

And probably explicitly specified inline too.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170420/64f3789d/attachment.html>

More information about the webkit-unassigned mailing list