[Webkit-unassigned] [Bug 170875] Cannot compile JavaScriptCore/runtime/VMTraps.cpp on FreeBSD because std::pair has a non-trivial copy constructor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 19 09:54:47 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170875

JF Bastien <jfbastien at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|webkit-unassigned at lists.web |jfbastien at apple.com
                   |kit.org                     |
 Attachment #307486|                            |review?, commit-queue?
              Flags|                            |

--- Comment #3 from JF Bastien <jfbastien at apple.com> ---
Created attachment 307486

  --> https://bugs.webkit.org/attachment.cgi?id=307486&action=review

patch

(In reply to Ting-Wei Lan from comment #2)
> (In reply to JF Bastien from comment #1)
> > It is surprising to see the constexpr version being instantiated here.
> 
> JSC::VM*, WTF::StackBounds, JSC::VMTraps::Error are all trivially
> destructible, so WTF::ExpectedDetail::BaseSelect is
> WTF::ExpectedDetail::ConstexprBase here.

Derp, right you are!

Here's a patch that works around the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170419/98e70b98/attachment.html>


More information about the webkit-unassigned mailing list