[Webkit-unassigned] [Bug 167343] webkit-gtk-2.15.3 fails to build on macOS due to missing declaration of U8_MAX_LENGTH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 18 19:23:27 PDT 2017


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |sam at webkit.org

--- Comment #4 from Sam Weinig <sam at webkit.org> ---
(In reply to John Ralls from comment #1)
> Created attachment 307443 [details]
> Rename Source/WTF/wtf/unicode/UTF8.h to .../wtf_utf8.h
> This problem has a long history: Bugs 63948, 65811, 70913, 72152, and 88307.
> The "fix" implemented in a patch at bug 70913 worked until CMake came along,
> but now CMake's dependency-discovery mechanism appends Source/WTF/wtf to the
> include list and ICU's #include "unicode/utf8.h" (in unicode/utf.h) finds it
> again.
> This patch renames the offending UTF8.h and UTF8.cpp to wtf_utf8.h and
> wtf_utf8.cpp, which is what should have been done in the first place.

wtf_utf8.h/cpp doesn't really match out naming at all.  If this rename does need to happen, though I admit, I don't quite understand why that is, it should probably follow the String classes lead, and be called WTFUTF8.h, hideous though that be.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170419/67b93682/attachment.html>

More information about the webkit-unassigned mailing list