[Webkit-unassigned] [Bug 166695] [ESNext] Async iteration - Implement Async Generator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 17 20:18:27 PDT 2017


--- Comment #58 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307013
  --> https://bugs.webkit.org/attachment.cgi?id=307013

View in context: https://bugs.webkit.org/attachment.cgi?id=307013&action=review

Wowza, this is a huge patch. I need to review the spec before I can responsibly review this. I'll get back to this tomorrow.

Maybe Yusuke/Caitlin can also take a look, since they implemented generators/async functions.

> Source/JavaScriptCore/ChangeLog:8
> +        Current implementation is draft version of Async Iteration. 

Can you link to the spec here?

> Source/JavaScriptCore/builtins/AsyncFromSyncIteratorPrototype.js:153
> +                                              function(result) {  promiseCapability. at resolve.@call(@undefined, { value: result, done }); },
> +                                              function(error) {  promiseCapability. at reject.@call(@undefined, error); });

style: indentation should be 4 lines from the statement's starting indentation

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170418/09379fca/attachment.html>

More information about the webkit-unassigned mailing list