[Webkit-unassigned] [Bug 170859] webkit-patch failed to detect git repository

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170859

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307162|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 307162
  --> https://bugs.webkit.org/attachment.cgi?id=307162
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307162&action=review

The change looks good. The ChangeLog is out-of-date and I noticed some minor stylistic issues with it. Please update it. You do not need to post this patch for review again (though feel free to ask for one if you want one or make changes other than fixing the ChangeLog entry). When you update the ChangeLog entry change the  "Reviewed by NOBODY (OOPS!)" line to "Reviewed by Daniel Bates." and upload the patch without a review flag and with the cq flag set to ?.

> Tools/ChangeLog:3
> +        webkit-patch failed to detect git repository.

Minor: Remove the period at the end of this line so that it matches the Bugzilla title verbatim.

> Tools/ChangeLog:8
> +        When -C is given to git, using double quotes for the path.

Please add an empty line below this line.

> Tools/ChangeLog:10
> +        * Scripts/VCSUtils.pm:
> +        (isGitDirectory):

This file/function listing is out-of-date. Please generate this ChangeLog entry again using prepare-ChangeLog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170414/4f99fa9f/attachment.html>