[Webkit-unassigned] [Bug 170851] GraphicsLayerCA::recursiveCommitChanges should not descend into subtrees without changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 14 14:51:43 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170851

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307125|review?                     |review+
              Flags|                            |

--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 307125
  --> https://bugs.webkit.org/attachment.cgi?id=307125
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307125&action=review

Nice, I always wanted to do this.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4033
> +        if (ancestorCA.m_hasDescendantsWithUncommittedChanges)
> +            return;
> +        ancestorCA.m_hasDescendantsWithUncommittedChanges = true;

I would prefer you go through a setter and not poke the member variable directly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170414/77d31a57/attachment.html>


More information about the webkit-unassigned mailing list