[Webkit-unassigned] [Bug 170705] Web Inspector: No context menu available via ENABLE_INSPECTOR_SERVER

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 13 20:19:54 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170705

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307072|review?                     |review+
              Flags|                            |

--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 307072
  --> https://bugs.webkit.org/attachment.cgi?id=307072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307072&action=review

Excellent! r=me

> Source/WebInspectorUI/UserInterface/Views/SoftContextMenu.css:3
> + * Copyright (C) 2017 Sony Interactive Entertainment Inc.

Can you add this line to $inspectorLicense in Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl

That is the copyright included appended to minified builds. I normally roll it every now and then but since I remembered now we should add this proactively!

> Source/WebInspectorUI/UserInterface/Views/SoftContextMenu.js:195
> +        // Squelch native Inspect Element.

I don't think "Squelch" is clear terminology.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170414/7a0e23ca/attachment.html>


More information about the webkit-unassigned mailing list