[Webkit-unassigned] [Bug 170676] Cache small media resources in disk cache
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 12 01:36:46 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=170676
Andreas Kling <akling at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |akling at apple.com
Attachment #306893|review? |review+
Flags| |
--- Comment #17 from Andreas Kling <akling at apple.com> ---
Comment on attachment 306893
--> https://bugs.webkit.org/attachment.cgi?id=306893
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=306893&action=review
r=me
> Source/WebCore/loader/MediaResourceLoader.h:58
> + Vector<ResourceResponse> responsesForTesting() const { return m_responsesForTesting; }
This could return a const Vector<ResourceResponse>& I suppose, though if it's just for testing it matters less.
> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:238
> + if (StringView(contentRange).left(6) != ASCIILiteral("bytes "))
> + return { };
I would write this using contentRange.startsWith().
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170412/94f3b1ad/attachment.html>
More information about the webkit-unassigned
mailing list