[Webkit-unassigned] [Bug 170693] Adopt AVKit name change from AVFunctionBar* to AVTouchBar*

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 11 21:25:08 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170693

--- Comment #10 from Beth Dakin <bdakin at apple.com> ---
(In reply to Wenson Hsieh from comment #9)
> Comment on attachment 306867 [details]
> Another bots patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306867&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:5008
> > +- (id)_mediaPlaybackControlsView
> 
> Can these be something a bit more specific, like NSView?

Yeah, the id is not great. I think this can be fixed if I adopt Tim's suggestion of only typedef'ing on the old OS, and using the name from the new OS. That way there is only one name to forward declare, which is what we used to do.

Patch forthcoming!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170412/18130356/attachment.html>


More information about the webkit-unassigned mailing list