[Webkit-unassigned] [Bug 170362] Add SPI for handling geolocation authorization requests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 10 18:04:09 PDT 2017


--- Comment #13 from David Quesada <david_quesada at apple.com> ---
(In reply to Alex Christensen from comment #12)
> Comment on attachment 306761 [details]
> Patch v2
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306761&action=review
> > Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm:78
> > +static inline RefPtr<WebGeolocationPosition> kit(WebCore::GeolocationPosition *position)
> Let's make this return a Ref, and make WebGeolocationPosition::create return
> a Ref instead of a PassRefPtr.  This will require dereferencing the newly
> allocated pointer, which we commonly do in WebKit.
> return adoptRef(*new WebGeolocationPosition ...


> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm:28
> It looks like this API test will run on Mac, and I'm not sure what will
> happen if it does.  Maybe we could make this test run on Mac, maybe we
> should make it just run on iOS.

I'll make the tests only run on iOS. The new delegate method and the ability to swap out a location provider are only compiled on iOS, so it doesn't make sense to try to test them on Mac.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170411/d2ac6cb3/attachment.html>

More information about the webkit-unassigned mailing list