[Webkit-unassigned] [Bug 170362] Add SPI for handling geolocation authorization requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170362

--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 306761
  --> https://bugs.webkit.org/attachment.cgi?id=306761
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=306761&action=review

> Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm:78
> +static inline RefPtr<WebGeolocationPosition> kit(WebCore::GeolocationPosition *position)

Let's make this return a Ref, and make WebGeolocationPosition::create return a Ref instead of a PassRefPtr.  This will require dereferencing the newly allocated pointer, which we commonly do in WebKit.
return adoptRef(*new WebGeolocationPosition ...

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm:28
> +#if WK_API_ENABLED

It looks like this API test will run on Mac, and I'm not sure what will happen if it does.  Maybe we could make this test run on Mac, maybe we should make it just run on iOS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170411/50de04fb/attachment-0001.html>