[Webkit-unassigned] [Bug 170696] Have parseRevisionProperty use default repo name as the buildbot key.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 10 16:23:23 PDT 2017


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #306749|review?                     |review+
              Flags|                            |

--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 306749
  --> https://bugs.webkit.org/attachment.cgi?id=306749

View in context: https://bugs.webkit.org/attachment.cgi?id=306749&action=review

> Tools/ChangeLog:9
> +        buildobt data. That is no longer necessary as we can make a safe assumption

buildobt => Buildbot

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:208
> +            var key = repositoryName;

Instead of default initializing these variables and then overwriting them for OpenSiurce I suggest that we leave them hninitialized here and remove the "else if" For Internal.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170410/b303ca78/attachment-0001.html>

More information about the webkit-unassigned mailing list