[Webkit-unassigned] [Bug 170093] Add API to get available content extension identifiers in a WKContentExtensionStore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 10 11:00:41 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170093

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305352|review?                     |review+
              Flags|                            |

--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 305352
  --> https://bugs.webkit.org/attachment.cgi?id=305352
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305352&action=review

r=me

> Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp:404
> +            completionHandler(identifiers);

I think you need to WTFMove(identifiers) again in this argument expression or you will copy the vector. (The capture expression creates an rvalue reference by WTFMove, but immediately assigns that reference to an lvalue named "identifiers".)

> Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.mm:115
> +        NSMutableArray<NSString *> *nsIdentifiers = [NSMutableArray arrayWithCapacity:100];

Why not use the capacity in identifiers?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170410/f1637138/attachment-0001.html>


More information about the webkit-unassigned mailing list