[Webkit-unassigned] [Bug 170593] New: [CMake][Windows] WebKitGUID.lib should be built with the release CRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170593

            Bug ID: 170593
           Summary: [CMake][Windows] WebKitGUID.lib should be built with
                    the release CRT
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Hironori.Fujii at sony.com
                CC: achristensen at apple.com, bfulgham at webkit.org,
                    pvollan at apple.com

Source/cmake/OptionsWin.cmake has a following trick to force using /MT.

>  foreach (flag_var
>      CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE
>      CMAKE_CXX_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_RELWITHDEBINFO)
>      # Use the multithreaded static runtime library instead of the default DLL runtime.
>      string(REGEX REPLACE "/MD" "/MT" ${flag_var} "${${flag_var}}")
>
>      # No debug runtime, even in debug builds.
>      if (NOT DEBUG_SUFFIX)
>          string(REGEX REPLACE "/MTd" "/MT" ${flag_var} "${${flag_var}}")
>          string(REGEX REPLACE "/D_DEBUG" "" ${flag_var} "${${flag_var}}")
>      endif ()
>  endforeach ()

But, this trick affect only to C++, but C.
As the result, WebKitGUID.lib is build with debug CRT because it has C source files.

The below warning messages are reported by this issue.

> LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170407/9868103b/attachment.html>