[Webkit-unassigned] [Bug 170568] Web Inspector: WebSockets: frame context menu items should content sniff to be more relevant

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 6 15:22:04 PDT 2017


--- Comment #9 from Brian Burg <bburg at apple.com> ---
(In reply to Joseph Pecoraro from comment #5)
> (In reply to Brian Burg from comment #0)
> > Currently we have "Log Frame Text" and "Log Frame Value". The latter logs
> > the frame as JSON, whether or not it actually is JSON.
> I'm having trouble understanding this. We do know it is actually JSON, we've
> done a JSON.parse() on the contents to prove it.
> > We should sniff the values prior to appending the menu items. If it is
> > JSON, have "Log Frame as JSON" and "Log Frame as Text". If it's not
> > JSON, then the option should be "Log Frame Value".
> My expectations are:
>    (1) if the frame is text => have a Log Text option
>    (2) if the text is JSON  => have a Log Value option
> which currently matches the code.
> Is there a specific case where the context menus were confusing?

"Value" is kinda confusing IMO since the text representation *is* the value. as JSON or as String would be clearer to me.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170406/79c56882/attachment.html>

More information about the webkit-unassigned mailing list