[Webkit-unassigned] [Bug 170351] JavaScriptCore: Do not use BLX for immediates (ARM-32)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 5 10:28:23 PDT 2017


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
 Attachment #306108|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #15 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 306108
  --> https://bugs.webkit.org/attachment.cgi?id=306108
The patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=306108&action=review

> Source/JavaScriptCore/ChangeLog:24
> +        this change the BL instruction will only be used on non iOS targets.

Replace /non iOS/non-darwin/ since that's what the patch actually does.

> Source/JavaScriptCore/offlineasm/arm.rb:97
> +IS_IOS = ((RUBY_PLATFORM =~ /darwin/i) != nil)

Let's rename IS_IOS to OS_DARWIN.  The name should reflect what it's really checking.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170405/b80648d6/attachment-0001.html>

More information about the webkit-unassigned mailing list