[Webkit-unassigned] [Bug 170362] Add SPI for handling geolocation authorization requests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 5 10:02:40 PDT 2017


Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |achristensen at apple.com

--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 306015
  --> https://bugs.webkit.org/attachment.cgi?id=306015

View in context: https://bugs.webkit.org/attachment.cgi?id=306015&action=review

Test failure seems unrelated.  This looks good.  It seems like we had a synchronous callback and this adds an asynchronous one.
You should make an API test that opens a page that requests geolocation data and asynchronously call the decisionHandler with a callOnMainThread in the delegate callback that calls the decisionHandler.  Then we can do things like test the behavior if the delegate callback isn't there, test the behavior if we call the callback twice, make sure there are no use-after-free bugs on the asan bots, make sure the expected behavior happens in JavaScript when a request is accepted and denied, etc.

> Source/WebKit2/UIProcess/ios/WKGeolocationProviderIOS.mm:185
> +            URL requestFrameURL(URL(), request.frame->url());

Can't we just call the copy constructor here?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170405/911c1753/attachment.html>

More information about the webkit-unassigned mailing list