[Webkit-unassigned] [Bug 170390] WebAssembly: several tests added in r214504 crash when building with GCC

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 3 09:14:36 PDT 2017


--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 306063
  --> https://bugs.webkit.org/attachment.cgi?id=306063
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306063&action=review

>>>> Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:94
>>>> +        p.vm().promiseDeferredTimer->scheduleWorkSoon(promise, [source, promise, globalObject, plan = makeRefPtr(p)] () mutable {
>>> Why not plan=WTFMove(plan)?
>> Because I've removed the line that created the plan to simplify it. 
>> RefPtr<Plan> plan = makeRef(p);
>> [plan = WTFMove(plan)]
>> is equivalent to 
>> [plan = makeRefPtr(p)]
>> I think this way is simpler, since we were only creating the plan to transfer it to the lambda capture (and to get the vm, but that is what caused the crash).
> Gotcha. I see what's going on.
> I still think you need a local variable for the plan, otherwise, won't the lambda capture the outermost plan? I think that'll lead to a reference cycle.
> Even if that assignment doesn't cause this to happen, I think it's harder to reason about than just having a local variable.

Seems like you could also keep the code as is, and just use p.vm() instead of plan->vm().
Also, I'm not sure why we make a RefPtr instead of a Ref here.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170403/1911a431/attachment.html>

More information about the webkit-unassigned mailing list