[Webkit-unassigned] [Bug 170390] WebAssembly: several tests added in r214504 crash when building with GCC

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 3 03:26:34 PDT 2017


--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Saam Barati from comment #6)
> Comment on attachment 306063 [details]
> Updated patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306063&action=review
> > Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:94
> > +        p.vm().promiseDeferredTimer->scheduleWorkSoon(promise, [source, promise, globalObject, plan = makeRefPtr(p)] () mutable {
> Why not plan=WTFMove(plan)?

Because I've removed the line that created the plan to simplify it. 

RefPtr<Plan> plan = makeRef(p);
[plan = WTFMove(plan)]

is equivalent to 

[plan = makeRefPtr(p)]

I think this way is simpler, since we were only creating the plan to transfer it to the lambda capture (and to get the vm, but that is what caused the crash).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170403/fbf25088/attachment.html>

More information about the webkit-unassigned mailing list