[Webkit-unassigned] [Bug 170272] MathML: Extra left space for arrows inside <mo>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 3 02:06:33 PDT 2017


--- Comment #9 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
(In reply to Minsheng Liu from comment #7)
> Thanks for the feedback. I will look at it when I have more time later this
> week. 
> However, I do have some question regarding the tests, as I am completely new
> to WebKit hacking. Hours ago, I run a WebKit test on my modified build.
> While there were many issues, none of them were related with MathML. I
> expect at least some diffs in MathML tests. Are MathML tests in LayoutTests/
> automated or manual? What is the right way to see whether I have broken
> existing *MathML* code or not?

On which platform do you work?

Tests are executed automatically with the run-webkit-tests (you can restrict execution to Layout/mathml/). Two things to note:

1) It is possible that our test coverage is limited and hence does not detect your changes, that's why we always add new tests when we fix a bug.

2) There are some tests (pixel tests) which compare against an expected render tree (txt file) and visual rendering (PNG image). However, if your code changes visual rendering but to the render tree, the test runner will still consider the test to pass. That's very likely to be the case if you only modify RenderMathMLToken::paint here. That's why it's often better to use reftests or javascript tests.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170403/c6cef8cb/attachment.html>

More information about the webkit-unassigned mailing list