[Webkit-unassigned] [Bug 162814] Web Inspector: TestSuite test cases should have their own timeout to ensure tests fail with output instead of timeout by test runner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162814

--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
(In reply to comment #2)
> So, it will check elapsed time before continuing to the next test case? Or
> would we start a JS watchdog timer for each testcase that will abort the
> entire suite?

Correct, I was thinking a setTimeout for each test case.

Either aborting the entire suite or a single test case. Both are fine, As long as we get some output. The safest thing to do is abort everything, but sometimes that isn't needed and it would be nice to run other test cases that may pass afterwards.

> I fear that if the real problem is the bots are simply too contended or
> slow, then a watchdog timer in JS will just get stuck like the test and be
> ineffective. If it's a flake even on a fast machine, then this seems like a
> decent mitigation.

Almost always, especially locally when authoring a test, some event doesn't fire and the test times out. The only way I can debug that now is InspectorTest.debug() and a lot of waiting.

> I think a separate issue is that we don't get partial test output when a
> test times out, even if multiple things have been sent back to the test
> page. It would be nice to get a warning event sent from the test runner when
> it's about to kill the test so we could flush any buffered test results.

Correct. I think this would be easier for TestSuite to do it. Especially considering this is really an issue for our tests, many other tests don't buffer things like us.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161001/fbb241cb/attachment-0001.html>