[Webkit-unassigned] [Bug 162705] Offline asm should not output masm assembly when using a x86_64 asm backend

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 30 13:08:19 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=162705

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bfulgham at webkit.org

--- Comment #22 from Brent Fulgham <bfulgham at webkit.org> ---
(In reply to comment #20)
> If not, then I don't think we should take the patch into trunk, since there
> would be no way for a WebKit developer to validate whether a change to the
> code you add would be valid for you.  In fact, the new code would be dead
> code from the standpoint of the WebKit project.

I am in favor of taking this change for the following reasons:
1. Visual Studio now ships with a Clang front-end, which I would like to start using. The work the Sony people are doing helps in this effort, and would save time for me and PerArne.
2. I think the amount of 'dead code' we are talking about there is likely to be small.
3. If we break the Sony build during a period of time that they do not have a buildbot, it's on them to track down and fix the problem.

Therefore, I don't see much downside in allow this work to proceed. If it becomes a problem, we can roll out the changes in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160930/c9e33a04/attachment.html>


More information about the webkit-unassigned mailing list