[Webkit-unassigned] [Bug 162705] Offline asm should not output masm assembly when using a x86_64 asm backend

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 30 11:10:28 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=162705

--- Comment #21 from Don Olmstead <don.olmstead at am.sony.com> ---
(In reply to comment #20)
> Is there a bot that builds in this configuration hooked up to
> build.webkit.org?
> 
> If not, then I don't think we should take the patch into trunk, since there
> would be no way for a WebKit developer to validate whether a change to the
> code you add would be valid for you.  In fact, the new code would be dead
> code from the standpoint of the WebKit project.
> 
> I think it's best for these kinds of changes to be kept downstream until you
> have a bot on build.webkit.org.

We do not yet have a build bot going. The porting guide says that before we create the build bot we should have JavaScriptCore building and the tests running. We've been picking off different things that prevent us from building from trunk and this is one of those things. At that point we'll be spinning up a build bot.

Since there are no guarantees that we'll be able to land a port we've been trying to keep our downstream changes to just be CMake files and platform specific code. In our case since we're cross compiling with Clang on Windows this script fails for us. The behavior of the script as is is technically wrong since rather than using the active backend it assumes MASM when Windows is used. So we're attempting a fix here.

We're still new to contributing to WebKit and really appreciate all the help. We'd really like to land a patch here so we can get JSC compiling out of the box. I can see the scope of this is expanding quite a bit but we're more than happy to work through any issues you see with the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160930/f7d3813c/attachment.html>


More information about the webkit-unassigned mailing list