[Webkit-unassigned] [Bug 162705] Offline asm should not output masm assembly when using a x86_64 asm backend

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 29 15:01:57 PDT 2016


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
 Attachment #290146|1                           |0
        is obsolete|                            |

--- Comment #11 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 290146
  --> https://bugs.webkit.org/attachment.cgi?id=290146

View in context: https://bugs.webkit.org/attachment.cgi?id=290146&action=review

> Source/JavaScriptCore/offlineasm/x86.rb:142
>  def isIntelSyntax
> -    isCompilingOnWindows
> +    isWin
>  end

It looks like this change is the only one that is of consequence.  All the other changes below only change the code to use a local var (initialized by a function) instead of a global var.  Are they really necessary?  Or did I misread something?

I see that the isGCC and isMSVC functions are also based on isCompilingOnWindows.  isGCC is not used anywhere.  isMSVC is used for (1) determining the offlineasm output file format and (2) whether to enable DWARF2 debug annotations.  If you're cross compiling with Clang for a non-Windows target, wouldn't you want these configured like other clang builds too?

This is what I would do:
1. remove isGCC because it is not used.
2. change isMSVC to be based on isWin.
3. remove isCompilingOnWindows since it will no longer be in use.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160929/51b2f1df/attachment.html>

More information about the webkit-unassigned mailing list