[Webkit-unassigned] [Bug 72099] [WK2] Keyboard menu key should show context menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72099

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290188|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #30 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 290188
  --> https://bugs.webkit.org/attachment.cgi?id=290188
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290188&action=review

It introduces a linker error on Mac, r- for that. You should investigate why you can't use WebCore::EventHandler::sendContextMenuEventForKey in WebPage.cpp.

> Source/WebCore/ChangeLog:23
> +        the only right way if some element was focused on the page. If there

the only right way -> only the right way

> Source/WebCore/page/EventHandler.cpp:2825
> +        // Display the context menu in the middle of focused element as Chromium does.
> +        location = IntPoint(clippedRect.x() + clippedRect.width() / 2, clippedRect.y() + clippedRect.height() / 2);

FWIW I really don't think this is the desired behavior, in GTK+ apps the context menu is displayed with the pointer at one of the four corners, depending on how much space is available on the screen. But this is not a big deal, and centering the menu is certainly easier, I suppose....

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160929/d8e27b59/attachment.html>