[Webkit-unassigned] [Bug 72099] [WK2] Keyboard menu key should show context menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72099

--- Comment #28 from Tomas Popela <tpopela at redhat.com> ---
I decided to move the issue of no context menu when no element to focused to another bug, to not block this one.

(In reply to comment #27)
> So, if it's covered by existing tests, what tests pass after this change?
> Can we unskip any test, or are those currently failing with no
> expectations?. I think it would be great for the GTK+ port if we add a test
> case for this to our current context menu unit tests.

I will test the popup-menu handling in TestContextMenu. Also there are manual tests that are testing this issue:

ManualTests/keyboard-menukey-event.html
ManualTests/win/contextmenu-key.html
ManualTests/win/contextmenu-key2.html

> I also wonder if we should prevent
> sending this key event to the web process, since it's going to be handled by
> context menu key event, or returning TRUE from webkitWebViewBasePopupMenu
> already prevents this?

Actually the key-press-event is emitted before the popup-menu one so we don't need to handle this at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160928/e867868a/attachment.html>