[Webkit-unassigned] [Bug 161806] [GTK] REGRESSION(r205650): ARM build broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161806

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thorton at apple.com

--- Comment #5 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to comment #3)
> The problem seems to be URLParser unit test using wchar_t in:
> 
> template<size_t length>
> static String wideString(const wchar_t (&url)[length])
> {
>     StringBuilder builder;
>     builder.reserveCapacity(length - 1);
>     for (size_t i = 0; i < length - 1; ++i)
> 	builder.append(url[i]);
>     return builder.toString();
> }
> 
> ../../Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp: In instantiation of
> ‘WTF::String TestWebKitAPI::wideString(const wchar_t (&)[length]) [with
> unsigned int length = 23u]’:
> ../../Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:245:60:   required
> from here
> ../../Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:93:9: error: call of
> overloaded ‘append(const wchar_t&)’ is ambiguous
>          builder.append(url[i]);
>          ^
> ../../Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:93:9: note: candidates
> are:
> ......
> 
> I guess wchar_t is defined differently in that ARM bot, maybe we could
> simply use UChar there. Any idea Alex?

The type definition for wchar_t is architecture dependent:

GNU/Linux x86_64 machine $ echo "" | gcc -E - -dM | grep WCHAR
#define __WCHAR_MAX__ 2147483647
#define __WCHAR_MIN__ (-__WCHAR_MAX__ - 1)
#define __GCC_ATOMIC_WCHAR_T_LOCK_FREE 2
#define __WCHAR_TYPE__ int
#define __SIZEOF_WCHAR_T__ 4


GNU/Linux i686 machine $ echo "" | g++-4.9 -E - -dM | grep WCHAR
#define __WCHAR_MAX__ 2147483647L
#define __WCHAR_MIN__ (-__WCHAR_MAX__ - 1)
#define __GCC_ATOMIC_WCHAR_T_LOCK_FREE 2
#define __WCHAR_TYPE__ long int
#define __SIZEOF_WCHAR_T__ 4


GNU/Linux armv7t machine $ echo "" | g++-4.9 -E - -dM | grep WCHAR
#define __ARM_SIZEOF_WCHAR_T 32
#define __WCHAR_MAX__ 4294967295U
#define __WCHAR_MIN__ 0U
#define __GCC_ATOMIC_WCHAR_T_LOCK_FREE 2
#define __WCHAR_TYPE__ unsigned int
#define __SIZEOF_WCHAR_T__ 4

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160926/f5b82cea/attachment.html>